Wikipedia:Bots/Requests for approval/Ahechtbot 5

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was  Approved.

Ahechtbot 5

• (BRFA
• Approved BRFAs
• talk
• contribs
• count
• SUL
• logs
• page moves
• block log
• rights log
• flag)

Operator: Ahecht (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 03:06, Sunday, February 17, 2019 (UTC)

Automatic, Supervised, or Manual: automatic

Programming language(s): AutoWikiBrowser

Source code available: AWB, replacement strings posted at User:Ahechtbot#Task 5

Function overview: Fixes the specific signatures and substituted template text with unclosed formatting tags listed at User:Ahechtbot#Task 4. These are now causing linter errors and/or formatting issues on entire pages due to the Change from HTML Tidy to RemexHTML. Also fixes unclosed <s>...</s> tags where found on pages where other changes are already being made.

Links to relevant discussions (where appropriate): Continuation of approved tasks at Wikipedia:Bots/Requests for approval/Ahechtbot, Wikipedia:Bots/Requests for approval/Ahechtbot_2, and Wikipedia:Bots/Requests for approval/Ahechtbot_3.

Edit period(s): Will be run in several batches.

Estimated number of pages affected: 25000

Exclusion compliant (Yes/No): Yes

Already has a bot flag (Yes/No): Yes

Function details: Continuation from Task 3 with another batch of strings to replace. These strings are listed at User:Ahechtbot#Task 5, and are based on the non-controversial strings from Task 4 as well as additional strings. No "Automatic changes" (genfixes, etc.) will be enabled. All edits will be marked as "bot" and "minor".

Discussion

I have some additional signature replacement patterns listed in the "//Fix Linter individual signatures" section of User:Jonesey95/AutoEd/doi.js, if you would like to replace those as well. I have never encountered a false positive in using those patterns. You might also consider the patterns in the "//font wrapping links - move inside link and convert to span tag" section as well; they catch a lot of "Tidy font link" errors. The three sections after that one all replace font tags, which are low-priority fixes but might benefit from getting done while your bot is visiting pages. I'm assuming that your bot will work primarily on Talk spaces and on Project space, since those are the spaces where user signatures are the most common. You might also consider a supervised run through the DYK pages in Template space, since those are really discussion pages. – Jonesey95 (talk) 09:32, 17 February 2019 (UTC)

I already have an unweildy amount of fixes for this run, but I can incorporate those additional signatures into Task 6. I especially don't want to muddy the waters by including general fixes in with the specific signatures that I'm targeting with this task. --Ahecht (TALK
PAGE) 15:25, 20 February 2019 (UTC)

• Approved for trial (100 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. 5 edits per replacement (I think my math is right on that). Primefac (talk) 20:31, 24 February 2019 (UTC)

  I already had edits for the first four replacement from my now-withdrawn BRFA for Task 4 (see Special:Contributions/Ahechtbot&offset=20181128032300&limit=24&target=Ahechtbot). I have done 80 test edits for the new replacements from this BRFA, which you can see at Special:Contributions/Ahechtbot&offset=20190310020000&limit=80&target=Ahechtbot. --Ahecht (TALK
  PAGE) 01:27, 10 March 2019 (UTC)

  I reviewed the edits, and they appear to have done no harm. Nice work. This edit should also fix the tidy font link error, like this. Also, it looks like the "Ichthus" changes need more work; here's how I followed up on one of the bot's edits. Thanks for taking on this task! – Jonesey95 (talk) 07:33, 10 March 2019 (UTC)

  @Jonesey95: I updated the ADH10 task to fix the font link error. I don't want to do HTML4→HTML5 edits such as swapping <font>...</font> for <span>...</span>, or swapping <br> for <br />, since they don't affect page display, but I did add some of the other Ichthus corrections. Since I had 20 test edits remaining, I did 5 more Ichthus and 5 more ADH10 edits, which can be seen here]. --Ahecht (TALK
  PAGE) 02:41, 17 March 2019 (UTC)

  Much better, and I'd be happy to see the bot run those edits. Those pesky Ichthus messages still need more work, but they are just harmless stripped closing div tags that do not really affect formatting; If they are not all the same pattern, then feel free to leave them out of the bot's work. Let's go ahead with this one, please, BAG editors. – Jonesey95 (talk) 05:22, 17 March 2019 (UTC)

  Ahecht I think you've forgotten to mark this as {{BotTrialComplete}}. Galobtter (pingó mió) 18:20, 20 March 2019 (UTC)

  @Galobtter: Thanks! Trial complete.. --Ahecht (TALK
  PAGE) 19:09, 20 March 2019 (UTC)

 Approved. Task approved with a ramp-up schedule. You may always go slower than this schedule:

1. 500 edits, 1 day hold
2. 500 edits, 1 day hold
3. 1000 edits, 2 day hold
4. 1500 edits, 3 day hold
5. open editing.

• Should any issues be brought requiring minor adjustments, restart the ramp-up. — xaosflux ^Talk 13:43, 28 March 2019 (UTC)

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.